Skip to content

bench: refactor random number generation in stats/base/dists/levy #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 22, 2025
Merged

bench: refactor random number generation in stats/base/dists/levy #6044

merged 10 commits into from
Mar 22, 2025
+225 −81

Conversation

hemantmm
Copy link
Contributor

Resolves #4977

Description

What is the purpose of this pull request?

This pull request:

  • Refactor random number generation in JS benchmarks for stats/base/dists/levy

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Sorry, something went wrong.

@hemantmm
Refactor random number generation in JS benchmarks
Loading
Loading status checks…
81f0e94 
Signed-off-by: hemantmm <[email protected]>
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 14, 2025
@hemantmm
new line added
Loading
Loading status checks…
d9db1de 
Signed-off-by: hemantmm <[email protected]>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 14, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/levy/cdf 234 / 234
+ 100.00 % 		21 / 21
+ 100.00 % 		3 / 3
+ 100.00 % 		234 / 234
+ 100.00 %
stats/base/dists/levy/ctor 420 / 420
+ 100.00 % 		32 / 32
+ 100.00 % 		16 / 16
+ 100.00 % 		420 / 420
+ 100.00 %
stats/base/dists/levy/entropy 120 / 120
+ 100.00 % 		7 / 7
+ 100.00 % 		1 / 1
+ 100.00 % 		120 / 120
+ 100.00 %
stats/base/dists/levy/logcdf 238 / 238
+ 100.00 % 		21 / 21
+ 100.00 % 		3 / 3
+ 100.00 % 		238 / 238
+ 100.00 %
stats/base/dists/levy/logpdf 222 / 222
+ 100.00 % 		21 / 21
+ 100.00 % 		3 / 3
+ 100.00 % 		222 / 222
+ 100.00 %
stats/base/dists/levy/mean 176 / 176
+ 100.00 % 		9 / 9
+ 100.00 % 		2 / 2
+ 100.00 % 		176 / 176
+ 100.00 %
stats/base/dists/levy/mode 175 / 175
+ 100.00 % 		9 / 9
+ 100.00 % 		2 / 2
+ 100.00 % 		175 / 175
+ 100.00 %
stats/base/dists/levy/pdf 216 / 216
+ 100.00 % 		21 / 21
+ 100.00 % 		3 / 3
+ 100.00 % 		216 / 216
+ 100.00 %
stats/base/dists/levy/stdev 176 / 176
+ 100.00 % 		9 / 9
+ 100.00 % 		2 / 2
+ 100.00 % 		176 / 176
+ 100.00 %
stats/base/dists/levy/variance 176 / 176
+ 100.00 % 		9 / 9
+ 100.00 % 		2 / 2
+ 100.00 % 		176 / 176
+ 100.00 %

The above coverage report was generated for the changes in this PR.

hemantmm added 2 commits March 14, 2025 16:36
@hemantmm
removed outside brackets
Loading
Loading status checks…
19543b1 
Signed-off-by: hemantmm <[email protected]>
@hemantmm
changes made
Loading
Loading status checks…
191511b 
Signed-off-by: hemantmm <[email protected]>
@hemantmm
Copy link
Contributor Author

@anandkaranubc have a look at the PR.

@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@hemantmm
Copy link
Contributor Author

@anandkaranubc any update?

@kgryte
Apply suggestions from code review
Loading
Loading status checks…
e08bc5a 
Signed-off-by: Athan <[email protected]>
kgryte added 2 commits March 22, 2025 16:14
@kgryte
Discard changes to lib/node_modules/@stdlib/stats/base/dists/levy/med…
Loading
Loading status checks…
1dd0b2b 
…ian/benchmark/benchmark.js
@kgryte
Discard changes to lib/node_modules/@stdlib/stats/base/dists/levy/med…
Loading
Loading status checks…
f8feef5 
…ian/benchmark/benchmark.native.js
kgryte added 2 commits March 22, 2025 16:17
@kgryte
Discard changes to lib/node_modules/@stdlib/stats/base/dists/levy/qua…
Loading
Loading status checks…
13108d8 
…ntile/benchmark/benchmark.js
@kgryte
Discard changes to lib/node_modules/@stdlib/stats/base/dists/levy/qua…
Loading
Loading status checks…
eea8798 
…ntile/benchmark/benchmark.native.js
@kgryte
Apply suggestions from code review
Loading
Loading status checks…
b0f6bff 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte added Benchmarks Pull requests adding or improving benchmarks for measuring performance. and removed Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue. labels Mar 22, 2025
@kgryte kgryte mentioned this pull request Mar 22, 2025
Closed
1 task
@kgryte kgryte merged commit 73050cb into stdlib-js:develop Mar 22, 2025
29 checks passed
Girish-Garg pushed a commit to Girish-Garg/stdlib that referenced this pull request Mar 23, 2025
@hemantmm @kgryte @Girish-Garg
bench: refactor random number generation in stats/base/dists/levy
65df310 
PR-URL: stdlib-js#6044
Closes: stdlib-js#4977
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: hemantmm <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 26, 2025
@hemantmm @kgryte @sahil20021008
bench: refactor random number generation in stats/base/dists/levy
4b25793 
PR-URL: stdlib-js#6044
Closes: stdlib-js#4977
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: hemantmm <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte

Assignees
No one assigned
Labels
Benchmarks Pull requests adding or improving benchmarks for measuring performance. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/levy
4 participants
@hemantmm @stdlib-bot @kgryte @Planeshifter